Fix/some relesases did not have translations of all languages #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdovhanych
approved these changes
Aug 4, 2025
obrusvit
approved these changes
Aug 4, 2025
Contributor
obrusvit
left a comment
obrusvit
left a comment
There was a problem hiding this comment.
Thank you and sorry for not catching it earlier. I will also create an issue in trezor-suite-firmware-releases repo because the generator is not ready for handling missing translations.
| "it-IT": "firmware/translations/t2b1/translation-t2b1-it-IT-2.6.3.bin", | ||
| "pt-BR": "firmware/translations/t2b1/translation-t2b1-pt-BR-2.6.3.bin" | ||
| }, | ||
| "translations": {}, |
Contributor
There was a problem hiding this comment.
So if this field is empty, we will try to find translations with lower version?
Member
Author
There was a problem hiding this comment.
I think if this field is empty then that version cannot get translated, the user will have to update to latest and then translate it. right?
Contributor
There was a problem hiding this comment.
No.
What it means is that for the version we didn't sign translations because they didn't change. That means that the translations from previous version are valid.
vdovhanych
deleted the
fix/some-relesases-did-not-have-translations-of-all-languages
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correcting 2 mistakes in the new releases JSONs:
firmware/translations/t2b1/translation-T2B1-cs-CZ-2.8.10.binI added new check to script
scripts/check-firmware-presence-in-releases-json-separated.shthat checks that all the releases JSON contain translations binary that exist in the repository.