Skip to content

Commit

Permalink
Globally replace <(library) with static_library
Browse files Browse the repository at this point in the history
We provided <(library) as a variable to support a peculiar
build configuration on Linux.  We no longer support that build
configuration, so we can simplify this code to no longer use
a variable.

Review URL: http://codereview.chromium.org/7051014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86004 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
evan@chromium.org committed May 19, 2011
1 parent ab03674 commit 5a54733
Show file tree
Hide file tree
Showing 89 changed files with 157 additions and 160 deletions.
4 changes: 2 additions & 2 deletions app/app_base.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
'targets': [
{
'target_name': 'app_base',
'type': '<(library)',
'type': 'static_library',
'msvs_guid': '4631946D-7D5F-44BD-A5A8-504C0A7033BE',
'variables': {
'app_base_target': 1,
Expand Down Expand Up @@ -324,7 +324,7 @@
'targets': [
{
'target_name': 'app_base_nacl_win64',
'type': '<(library)',
'type': 'static_library',
'msvs_guid': '4987C6F9-B230-48E5-BF91-418EAE69AD90',
'dependencies': [
# app resources and ui_strings should be shared with the 32-bit
Expand Down
2 changes: 1 addition & 1 deletion base/allocator/allocator.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
'targets': [
{
'target_name': 'allocator',
'type': '<(library)',
'type': 'static_library',
'msvs_guid': 'C564F145-9172-42C3-BFCB-60FDEA124321',
'include_dirs': [
'.',
Expand Down
10 changes: 5 additions & 5 deletions base/base.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
'targets': [
{
'target_name': 'base_i18n',
'type': '<(library)',
'type': 'static_library',
'msvs_guid': '968F3222-9798-4D21-BE08-15ECB5EF2994',
'dependencies': [
'base',
Expand Down Expand Up @@ -60,7 +60,7 @@
# dynamic library. Note that this library cannot depend on base because
# base depends on base_static.
'target_name': 'base_static',
'type': '<(library)',
'type': 'static_library',
'sources': [
'base_switches.cc',
'base_switches.h',
Expand All @@ -75,7 +75,7 @@
# TODO(rvargas): Remove this when gyp finally supports a clean model.
# See bug 36232.
'target_name': 'base_static_win64',
'type': '<(library)',
'type': 'static_library',
'sources': [
'base_switches.cc',
'base_switches.h',
Expand Down Expand Up @@ -293,7 +293,7 @@
},
{
'target_name': 'test_support_base',
'type': '<(library)',
'type': 'static_library',
'dependencies': [
'base',
'base_static',
Expand Down Expand Up @@ -335,7 +335,7 @@
},
{
'target_name': 'test_support_perf',
'type': '<(library)',
'type': 'static_library',
'dependencies': [
'base',
'../testing/gtest.gyp:gtest',
Expand Down
6 changes: 3 additions & 3 deletions base/base.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -604,7 +604,7 @@
'targets': [
{
'target_name': 'base_nacl_win64',
'type': '<(library)',
'type': 'static_library',
'msvs_guid': 'CEE1F794-DC70-4FED-B7C4-4C12986672FE',
'variables': {
'base_target': 1,
Expand Down Expand Up @@ -638,7 +638,7 @@
'targets': [
{
'target_name': 'symbolize',
'type': '<(library)',
'type': 'static_library',
'variables': {
'chromium_code': 0,
},
Expand All @@ -663,7 +663,7 @@
},
{
'target_name': 'xdg_mime',
'type': '<(library)',
'type': 'static_library',
'variables': {
'chromium_code': 0,
},
Expand Down
4 changes: 2 additions & 2 deletions base/third_party/dynamic_annotations/dynamic_annotations.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
'targets': [
{
'target_name': 'dynamic_annotations',
'type': '<(library)',
'type': 'static_library',
'msvs_guid': 'EF3AD1A1-5FA6-4B70-9CCC-F5AE4C6D0892',
'include_dirs': [
'../../../',
Expand All @@ -22,7 +22,7 @@
'targets': [
{
'target_name': 'dynamic_annotations_win64',
'type': '<(library)',
'type': 'static_library',
'msvs_guid': 'E8055455-0065-427B-9461-34A16FAD1973',
# We can't use dynamic_annotations target for win64 build since it is
# a 32-bit library.
Expand Down
8 changes: 4 additions & 4 deletions breakpad/breakpad.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
'targets': [
{
'target_name': 'breakpad_utilities',
'type': '<(library)',
'type': 'static_library',
'sources': [
'src/common/convert_UTF.c',
'src/client/mac/handler/breakpad_nlist_64.cc',
Expand Down Expand Up @@ -174,7 +174,7 @@
},
{
'target_name': 'breakpad',
'type': '<(library)',
'type': 'static_library',
'dependencies': [
'breakpad_utilities',
'crash_inspector',
Expand Down Expand Up @@ -283,7 +283,7 @@
'targets': [
{
'target_name': 'breakpad_client',
'type': '<(library)',
'type': 'static_library',

'sources': [
'src/client/linux/crash_generation/crash_generation_client.cc',
Expand Down Expand Up @@ -338,7 +338,7 @@
{
# Breakpad r693 uses some files from src/processor in unit tests.
'target_name': 'breakpad_processor_support',
'type': '<(library)',
'type': 'static_library',

'sources': [
'src/processor/basic_code_modules.cc',
Expand Down
6 changes: 3 additions & 3 deletions breakpad/breakpad_handler.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
'targets': [
{
'target_name': 'breakpad_handler',
'type': '<(library)',
'type': 'static_library',
'variables': {
'breakpad_handler_target': 1,
},
Expand All @@ -58,7 +58,7 @@
# BREAKPAD_NO_TERMINATE_THREAD as that define makes breakpad crash
# when created and destroyed in DllMain.
'target_name': 'breakpad_handler_dll',
'type': '<(library)',
'type': 'static_library',
'variables': {
'breakpad_handler_target': 1,
},
Expand All @@ -72,7 +72,7 @@
},
{
'target_name': 'breakpad_handler_win64',
'type': '<(library)',
'type': 'static_library',
'variables': {
'breakpad_handler_target': 1,
},
Expand Down
4 changes: 2 additions & 2 deletions breakpad/breakpad_sender.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
'targets': [
{
'target_name': 'breakpad_sender',
'type': '<(library)',
'type': 'static_library',
'msvs_guid': '9946A048-043B-4F8F-9E07-9297B204714C',
'variables': {
'breakpad_sender_target': 1,
Expand All @@ -41,7 +41,7 @@
},
{
'target_name': 'breakpad_sender_win64',
'type': '<(library)',
'type': 'static_library',
'msvs_guid': '237AEB58-9D74-41EF-9D49-A6ECE24EA8BC',
'variables': {
'breakpad_sender_target': 1,
Expand Down
6 changes: 3 additions & 3 deletions build/common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
'chromeos%': '<(chromeos)',
'touchui%': '<(touchui)',
'host_arch%': '<(host_arch)',
'library%': '<(library)',
'library%': 'static_library',
'toolkit_views%': '<(toolkit_views)',

# Override branding to select the desired branding flavor.
Expand Down Expand Up @@ -117,7 +117,7 @@
# 'library' for static libraries.
# By default, component is set to whatever library is set to and
# it can be overriden by the GYP command line or by ~/.gyp/include.gypi.
'component%': '<(library)',
'component%': 'static_library',

# Set to select the Title Case versions of strings in GRD files.
'use_titlecase_in_grd_files%': 0,
Expand Down Expand Up @@ -217,7 +217,7 @@
'arm_neon%': '<(arm_neon)',
'sysroot%': '<(sysroot)',
'disable_sse2%': '<(disable_sse2)',
'library%': '<(library)',
'library%': 'static_library',
'component%': '<(component)',
'use_titlecase_in_grd_files%': '<(use_titlecase_in_grd_files)',
'use_third_party_translations%': '<(use_third_party_translations)',
Expand Down
4 changes: 2 additions & 2 deletions chrome/app/policy/cloud_policy_codegen.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@
},
{
'target_name': 'policy',
'type': '<(library)',
'type': 'static_library',
'hard_dependency': 1,
'direct_dependent_settings': {
'include_dirs': [
Expand Down Expand Up @@ -174,7 +174,7 @@
'targets': [
{
'target_name': 'policy_win64',
'type': '<(library)',
'type': 'static_library',
'hard_dependency': 1,
'sources': [
'<(policy_constant_header_path)',
Expand Down
2 changes: 1 addition & 1 deletion chrome/browser/sync/protocol/sync_proto.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
},
{
'target_name': 'sync_proto_cpp',
'type': '<(library)',
'type': 'static_library',
'sources': [
'<(protoc_out_dir)/chrome/browser/sync/protocol/sync.pb.cc',
'<(protoc_out_dir)/chrome/browser/sync/protocol/sync.pb.h',
Expand Down
16 changes: 8 additions & 8 deletions chrome/chrome.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -416,7 +416,7 @@
},
{
'target_name': 'debugger',
'type': '<(library)',
'type': 'static_library',
'msvs_guid': '57823D8C-A317-4713-9125-2C91FDFD12D6',
'dependencies': [
'chrome_extra_resources',
Expand Down Expand Up @@ -477,7 +477,7 @@
},
{
'target_name': 'utility',
'type': '<(library)',
'type': 'static_library',
'msvs_guid': '4D2B38E6-65FF-4F97-B88A-E441DF54EBF7',
'dependencies': [
'../base/base.gyp:base',
Expand All @@ -501,7 +501,7 @@
},
{
'target_name': 'profile_import',
'type': '<(library)',
'type': 'static_library',
'dependencies': [
'../base/base.gyp:base',
],
Expand All @@ -515,7 +515,7 @@
# Provides a syncapi dynamic library target from checked-in binaries,
# or from compiling a stub implementation.
'target_name': 'syncapi',
'type': '<(library)',
'type': 'static_library',
'sources': [
'browser/sync/engine/http_post_provider_factory.h',
'browser/sync/engine/http_post_provider_interface.h',
Expand Down Expand Up @@ -553,7 +553,7 @@
},
{
'target_name': 'sync',
'type': '<(library)',
'type': 'static_library',
'sources': [
'browser/sync/engine/all_status.cc',
'browser/sync/engine/all_status.h',
Expand Down Expand Up @@ -740,7 +740,7 @@
# A library for sending and receiving server-issued notifications.
{
'target_name': 'sync_notifier',
'type': '<(library)',
'type': 'static_library',
'sources': [
'browser/sync/notifier/cache_invalidation_packet_handler.cc',
'browser/sync/notifier/cache_invalidation_packet_handler.h',
Expand Down Expand Up @@ -782,7 +782,7 @@
},
{
'target_name': 'service',
'type': '<(library)',
'type': 'static_library',
'msvs_guid': '2DA87614-55C5-4E56-A17E-0CD099786197',
'dependencies': [
'chrome_strings',
Expand Down Expand Up @@ -1469,7 +1469,7 @@
},
{
'target_name': 'automation',
'type': '<(library)',
'type': 'static_library',
'msvs_guid': '1556EF78-C7E6-43C8-951F-F6B43AC0DD12',
'dependencies': [
'theme_resources',
Expand Down
4 changes: 2 additions & 2 deletions chrome/chrome_browser.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
'targets': [
{
'target_name': 'browser',
'type': '<(library)',
'type': 'static_library',
'msvs_guid': '5BF908A7-68FB-4A4B-99E3-8C749F1FE4EA',
'dependencies': [
'app/policy/cloud_policy_codegen.gyp:policy',
Expand Down Expand Up @@ -4549,7 +4549,7 @@
},
{
'target_name': 'in_memory_url_index_cache_proto_cpp',
'type': '<(library)',
'type': 'static_library',
'sources': [
'<(protoc_out_dir)/chrome/browser/history/in_memory_url_index_cache.pb.cc',
'<(protoc_out_dir)/chrome/browser/history/in_memory_url_index_cache.pb.h',
Expand Down
6 changes: 3 additions & 3 deletions chrome/chrome_common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@
'targets': [
{
'target_name': 'common',
'type': '<(library)',
'type': 'static_library',
'msvs_guid': '899F1280-3441-4D1F-BA04-CCD6208D9146',
'variables': {
'chrome_common_target': 1,
Expand Down Expand Up @@ -350,7 +350,7 @@
},
{
'target_name': 'common_net',
'type': '<(library)',
'type': 'static_library',
'sources': [
'common/net/http_return.h',
'common/net/net_resource_provider.cc',
Expand Down Expand Up @@ -473,7 +473,7 @@
'targets': [
{
'target_name': 'common_nacl_win64',
'type': '<(library)',
'type': 'static_library',
'msvs_guid': '3AB5C5E9-470C-419B-A0AE-C7381FB632FA',
'variables': {
'chrome_common_target': 1,
Expand Down
6 changes: 3 additions & 3 deletions chrome/chrome_installer_util.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@
'targets': [
{
'target_name': 'installer_util',
'type': '<(library)',
'type': 'static_library',
'msvs_guid': 'EFBB1436-A63F-4CD8-9E99-B89226E782EC',
'variables': {
'installer_util_target': 1,
Expand Down Expand Up @@ -141,7 +141,7 @@
},
{
'target_name': 'installer_util_nacl_win64',
'type': '<(library)',
'type': 'static_library',
'msvs_guid': '91016F29-C324-4236-8AA0-032765E71582',
'variables': {
'installer_util_target': 1,
Expand Down Expand Up @@ -169,7 +169,7 @@
'targets': [
{
'target_name': 'installer_util',
'type': '<(library)',
'type': 'static_library',
'dependencies': [
'common_constants',
'chrome_resources',
Expand Down
Loading

0 comments on commit 5a54733

Please sign in to comment.