Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Big update #54

Merged
merged 16 commits into from
Mar 21, 2023
Merged

Big update #54

merged 16 commits into from
Mar 21, 2023

Conversation

trevorblades
Copy link
Owner

This PR updates the stack in the following ways:

  • Move from JS to TS
  • Move from a Node.js server to Netlify serverless functions
  • Upgrade countries-list, sift, and Apollo Server to their latest versions
  • Adds Country.currencies and Country.phones fields
  • Adds Stellate caching layer for faster responses and edge hosting

@netlify
Copy link

netlify bot commented Mar 21, 2023

Deploy Preview for resplendent-mandazi-1856d6 ready!

Name Link
🔨 Latest commit f426a4c
🔍 Latest deploy log https://app.netlify.com/sites/resplendent-mandazi-1856d6/deploys/641922ff24432d0008a53cfa
😎 Deploy Preview https://deploy-preview-54--resplendent-mandazi-1856d6.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@trevorblades trevorblades merged commit b5d5c99 into main Mar 21, 2023
@trevorblades trevorblades deleted the netlify branch March 21, 2023 03:22
@Pannekake
Copy link

Pannekake commented Mar 21, 2023

Hi @trevorblades! Im using using countries as a remote schema. Just got this today:

Query:
query MyQuery { countries {capital} }

Response:
{ "data": null, "errors": [ { "extensions": { "code": "INTERNAL_SERVER_ERROR", "stacktrace": [ "TypeError: Cannot read properties of undefined (reading 'toString')", " at isVanillaObject (/var/task/netlify/functions/graphql/graphql.js:50619:107)", " at createQueryOperations (/var/task/netlify/functions/graphql/graphql.js:50864:14)", " at createQueryOperation (/var/task/netlify/functions/graphql/graphql.js:50850:18)", " at createDefaultQueryOperation (/var/task/netlify/functions/graphql/graphql.js:51293:16)", " at createDefaultQueryTester (/var/task/netlify/functions/graphql/graphql.js:51302:18)", " at resolve (/var/task/netlify/functions/graphql/graphql.js:58100:42)", " at field.resolve (/var/task/netlify/functions/graphql/graphql.js:54949:22)", " at executeField (/var/task/netlify/functions/graphql/graphql.js:8987:24)", " at executeFields (/var/task/netlify/functions/graphql/graphql.js:8962:24)", " at executeOperation (/var/task/netlify/functions/graphql/graphql.js:8933:18)" ] }, "locations": [ { "column": 3, "line": 2 } ], "message": "Cannot read properties of undefined (reading 'toString')", "path": [ "countries" ] } ] }

@trevorblades
Copy link
Owner Author

@Pannekake could you tell me more about your remote schema setup? Are you using a particular service to stitch schemas or perform some sort of magic there?

Was this configuration working with the old version? I want to make sure this API continues to support all former use cases, so let's figure out how to make that happen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants