-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add magidoc documentation #46
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pelletier197
commented
Aug 19, 2022
@trevorblades any chance you can check this ? |
Looking great @pelletier197! 🎉 I tested out the site using I made a branch with a bunch of changes that make the linter happy again. Could you add me as a contributor to your fork, and then I can make a PR there? |
Done @trevorblades 😃 |
Thanks @pelletier197! 🍣 🍔 🌮 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added magidoc documentation. See the example output here: https://pelletier197.github.io/countries
Once merged, the documentation will automatically be deployed at https://trevorblades.github.io/countries
To simplify my life, I needed to extract the schema in a separate file. This is easier to get the schema for me, and will be simpler for you to add the comments.
Thank you!
Resolve #45