Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update inputs #1

Open
wants to merge 1 commit into
base: non-blocking-gamepad
Choose a base branch
from

Conversation

lmunier
Copy link

@lmunier lmunier commented May 23, 2020

Update to "work" on windows too.

I know that there is always some issues. Example gamepad is not working fluent on windows and there is some differences on axis mapping between windows and linux. It is not perfect but I fixe fcntl import on windows and some arguments in function that were missing.

Update to "work" on windows too.
Copy link
Owner

@trevorablett trevorablett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import statement change and the addition of and not WIN make sense to me, but I don't think changing the default arguments for the initialization of Keyboard is right. I'm not sure about how you're using the file, but when I use it, this line creates the DeviceManager object, and right now those arguments will overwrite the new default arguments that you've set anyways. Unfortunately, I don't have a windows machine to test this on, but I suspect what we want is something like:

if WIN:
    devices = DeviceManager(gamepad_read_block=True, keyboard_read_block=True)
else:
    devices = DeviceManager(gamepad_read_block=False, keyboard_read_block=False)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants