Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ::debug and ::warning annotations #43

Closed
alekseykulikov opened this issue Apr 1, 2020 · 1 comment
Closed

Use ::debug and ::warning annotations #43

alekseykulikov opened this issue Apr 1, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@alekseykulikov
Copy link
Member

An LHCI assertion supports error or warning status.
Currently, every annotation has an error status, where it lists errors and warnings separated visually.
If a URL only has warnings, the status should be a warning.

console.log("::warning some text%0Aafter new line")

We could also use ::debug annotations to report LH results or other useful information.
@alekseykulikov alekseykulikov added the enhancement New feature or request label Apr 1, 2020
@alekseykulikov alekseykulikov mentioned this issue Apr 7, 2020
Open
@alekseykulikov alekseykulikov mentioned this issue May 25, 2020
Merged
6 tasks
alekseykulikov added a commit that referenced this issue May 25, 2020
@alekseykulikov
#43 suport warning annotations
ff39658
alekseykulikov added a commit that referenced this issue May 25, 2020
@alekseykulikov
#43 don't require links for annotations
4f84d83
@alekseykulikov
Copy link
Member Author

treosh/lighthouse-ci-action@v3 supports warnings. ::debug annotations are not necessary since output is extended with all the extra information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alekseykulikov