Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display active users only in Activity Log filter #3084

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Display active users only in Activity Log filter #3084

merged 1 commit into from
Oct 22, 2024

Conversation

gagandeepb
Copy link
Contributor

@gagandeepb gagandeepb commented Oct 21, 2024 •
edited
Loading

Now only those usernames that correspond to active users are displayed in the users filter in the Activity Log page.

@gagandeepb gagandeepb changed the title Removes collapsing of deleted users Display active users only in Activity Log filters Oct 21, 2024
@gagandeepb gagandeepb changed the title Display active users only in Activity Log filters Display active users only in Activity Log filter Oct 21, 2024
@gagandeepb gagandeepb marked this pull request as ready for review October 22, 2024 08:27
@gagandeepb gagandeepb self-assigned this Oct 22, 2024
@gagandeepb gagandeepb added enhancement New feature or request elixir Pull requests that update Elixir code labels Oct 22, 2024
@nelsonkopliku nelsonkopliku added the env Create an ephimeral environment for the pr branch label Oct 22, 2024
nelsonkopliku
nelsonkopliku approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@nelsonkopliku nelsonkopliku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I labeled the PR as env, just to test it in the pr environment.

@nelsonkopliku nelsonkopliku added env Create an ephimeral environment for the pr branch and removed env Create an ephimeral environment for the pr branch labels Oct 22, 2024
@gagandeepb
Removes collapsing of deleted users
6051ff1 
... now only active usernames are displayed in the filter.
@gagandeepb gagandeepb force-pushed the show-only-active-users-in-filters branch from f22bd13 to 6051ff1 Compare October 22, 2024 09:42
@gagandeepb gagandeepb merged commit fb73194 into main Oct 22, 2024
30 checks passed
@gagandeepb gagandeepb deleted the show-only-active-users-in-filters branch October 22, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nelsonkopliku nelsonkopliku nelsonkopliku approved these changes

@balanza balanza balanza approved these changes

Assignees

@gagandeepb gagandeepb

Labels
elixir Pull requests that update Elixir code enhancement New feature or request env Create an ephimeral environment for the pr branch
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gagandeepb @balanza @nelsonkopliku