ActivityLog searching by metadata BE implementation #3059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gagandeepb
changed the title
gagandeepb
force-pushed
the
searching-by-metadata-impl
branch
2 times, most recently
from
302074d
to
44be4b1
Compare
gagandeepb
commented
Oct 23, 2024
lib/trento/postgrex/jsonpath.ex
Outdated
| @@ -0,0 +1,39 @@ | |||
| defmodule Trento.Postgrex.Jsonpath do | |||
There was a problem hiding this comment.
Adapted from here.
gagandeepb
force-pushed
the
searching-by-metadata-impl
branch
from
ca819c2
to
199410e
Compare
gagandeepb
commented
Nov 6, 2024
gagandeepb
added
enhancement
nelsonkopliku
force-pushed
the
searching-by-metadata-impl
branch
from
dce42cb
to
22ab724
Compare
nelsonkopliku
approved these changes
Nov 11, 2024
Containment is preferred over Existence.
This is needed to support the Postgres Jsonpath type.
...for search by metadata. Specifically, this adds functions that validate the search string and then parse it into the format expected by Jsonpath. This implementation can be extended to do key:value look ups as well as range/numeric equality look ups on integer fields at a later point.
... to the activity logs endpoint.
Makes capture binding late instead of early
...by breaking it into two
commit 16dc8856c5c7e2f4f3f86d5a2a35ca8c055ea370
Author: Gagandeep Bhatia <gagandeep.bhatia@suse.com>
Date: Tue Nov 5 12:00:40 2024 +0100
Adds tests
- Adapts the public interface of the parse module a bit to allow better inspection of failing parse cases.
- Parse failure is now an info level log message.
- Adds tests cases for parse success and failure
commit 5aa83a4d764682d5e40b8f2174539c89bc4c8fec
Author: Gagandeep Bhatia <gagandeep.bhatia@suse.com>
Date: Wed Oct 23 14:40:19 2024 +0200
Connects new parser implementation
... to the context module
commit df0065d127d7d6ce59cd1e7a10aac5dce2140b2c
Author: Gagandeep Bhatia <gagandeep.bhatia@suse.com>
Date: Wed Oct 23 13:25:02 2024 +0200
PoC PEG based query parser
Implements a parsing expression grammar (PEG) based metadata query parser that turns search strings into valid jsonpath expressions
This adds expected parses for given test cases to assert against
- support for Numeric ranges - Additional characters that the search regex will now accept - Tests fixed - Credo fixed
nelsonkopliku
force-pushed
the
searching-by-metadata-impl
branch
from
22ab724
to
1d7c32a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Searching by metadata BE implementation.