Fix flacky UserPage test #2914
Merged
Fix flacky UserPage test #2914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbulu89
approved these changes
Aug 21, 2024
| @@ -36,7 +36,9 @@ describe('UsersPage', () => { | |||
| await act(async () => { | |||
| renderWithRouter(<UsersPage />); | |||
| }); | |||
| expect(await screen.getByText('No data available')).toBeVisible(); | |||
| await waitFor(() => { | |||
There was a problem hiding this comment.
Let's remove the wairFors in the screen.getByText and only leave them for the toast.
even though only the last one is failing, i'm fine having it in all 3 of them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Long Ci runs may cause some timing issues in the UserPage test. Adding waitFor should help.
How was this tested?
Run locally multiple times, let's rerun it some times in the whole ci.
After running the ci 5 times, no more errors.