Validation global error #2743
Merged
Validation global error #2743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balanza
requested review from
a team,
nelsonkopliku and
gagandeepb
and removed request for
a team
nelsonkopliku
approved these changes
Jul 4, 2024
There was a problem hiding this comment.
Super, thanks!
Just a few paths to adjust, if you want, for the rest LGTM.
I am now realizing that in SUMA credentials modal there is no generic failure handling afaik, so this change could be beneficial there as well.
(I mean, you don't have to do that. Just saying that we now have the opportunity to improve other parts of the app 😉 )
assets/js/common/ActivityLogsSettingsModal/ActivityLogsSettingsModal.test.jsx
Outdated
Show resolved
Hide resolved
|
@nelsonkopliku super thanks for the suggestion, I actually used the automatic import but it's not that savvy... I'll find out if there are any eslint rules we can enforce, though |
Co-authored-by: Nelson Kopliku <nelson.kopliku@suse.com>
* Return CVEs from `v1/software_updates/errata_details/:advisory_name` * Create CVE factory
Co-authored-by: Nelson Kopliku <nelson.kopliku@suse.com>
nelsonkopliku
added a commit
that referenced
this pull request
Jul 8, 2024
This reverts commit ae5ba8f.
balanza
added a commit
that referenced
this pull request
Jul 9, 2024
* global error * Apply suggestions from code review Co-authored-by: Nelson Kopliku <nelson.kopliku@suse.com> * format * Return CVEs from `Errata Details` endpoint (#2733) * Return CVEs from `v1/software_updates/errata_details/:advisory_name` * Create CVE factory * global error * Apply suggestions from code review Co-authored-by: Nelson Kopliku <nelson.kopliku@suse.com> * format --------- Co-authored-by: Nelson Kopliku <nelson.kopliku@suse.com> Co-authored-by: Jamie Rodríguez <jamie.rodriguez@suse.com>
nelsonkopliku
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
getGlobalErrorutility to map server validation error that not relate to a field. The use case is to render failures coming from the server when fetching/saving data.This PR also applies the error handling as an improvement of #2727.
See unit tests for expected usage.