-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check execution policy e2e tests #2742
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!!
cy.login(user.username, password); | ||
}); | ||
|
||
cy.visit(`/clusters/${availableHanaCluster.id}/settings`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here we could have cy.contains('button', 'Start Execution').should('be.enabled');
|
||
cy.contains('button', 'Start Execution').should('be.disabled'); | ||
|
||
cy.contains('button', 'Start Execution').click({ force: true }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mouseover
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does not work because the button is disabled :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So maybe just better to check that the button is disabled?
We already test the tooltip in the unit tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the button is disabled because the checks are not selected, and wanda is not integrated and all the steps are missing, so I simply check that the tooltip it's not present, so it's disabled but not because of the policy, it's a little bit weird but rn it's what we have
cy.login(user.username, password); | ||
}); | ||
|
||
cy.visit(`/hosts/${selectedHost.agentId}/settings`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add Here we could have cy.contains('button', 'Start Execution').should('be.enabled');
7c54300
to
05bcb43
Compare
Description
Check execution policy e2e tests, clusters and hosts.
How was this tested?
Automated tests