Display CVEs and fixes in the advisory details page #2735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamie-suse
reviewed
Jul 4, 2024
jamie-suse
reviewed
Jul 4, 2024
jamie-suse
reviewed
Jul 4, 2024
jamie-suse
reviewed
Jul 4, 2024
jamie-suse
reviewed
Jul 4, 2024
jamie-suse
reviewed
Jul 4, 2024
jamie-suse
reviewed
Jul 4, 2024
jamie-suse
reviewed
Jul 4, 2024
jamie-suse
reviewed
Jul 4, 2024
jamie-suse
reviewed
Jul 4, 2024
jamie-suse
reviewed
Jul 4, 2024
jamie-suse
reviewed
Jul 4, 2024
dottorblaster
requested changes
Jul 4, 2024
There was a problem hiding this comment.
Besides the very valuable points raised by @jamie-suse, a couple things more 👍
Good job!
The factory was using faker.company.buzzNoun() which I suspect has a small pool of words to pick from. Using words.noun() makes is less flaky in my experience.
Thanks for taking the time to review my PR
janvhs
force-pushed
the
advisroy-details-cve-and-fixes
branch
from
be87485
to
da74eed
Compare
|
Just rebased it against main and verified it working with @jamie-suse their patches :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This MR displays the fixes and CVEs in the advisory details view
How was this tested?
The new Jest tests ensure that there is always a link to the corresponding Bugzilla issue. Furthermore it updates the other tests to follow the new component API
Did you update the documentation?
This MR does not require any changes to the existing documentation