Integrate TLint into CI #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dottorblaster
force-pushed
the
tlint
branch
2 times, most recently
from
7ac2ce7
to
65c9b9a
Compare
dottorblaster
force-pushed
the
tlint
branch
2 times, most recently
from
e5ff163
to
b7d48e6
Compare
fabriziosestito
suggested changes
Nov 18, 2022
dottorblaster
requested review from
arbulu89,
CDimonaco,
EMaksy,
nelsonkopliku,
rtorrero and
stefanotorresi
nelsonkopliku
approved these changes
Nov 18, 2022
arbulu89
approved these changes
Nov 18, 2022
There was a problem hiding this comment.
Nice!
Could we use external schemas to do the checking/
Wanda already has its own schema in the guides folder.
This way, we don't depend on updating the linter project if we change the checks structure and the schema.
We could add an optional flag for that, and provider the file.
What do you think?
arbulu89
reviewed
Nov 18, 2022
.github/workflows/ci.yaml
Outdated
| uses: actions/checkout@v3 | ||
| with: | ||
| fetch-depth: 0 | ||
|
|
There was a problem hiding this comment.
Remove newline here to be consistent with the rest of the file
|
@arbulu89 you are actually right, we have to do that using a build script, I tracked that as a ticket this morning 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrating TLint into the CI so no new checks hit
mainif not compliant