Detect already running execution for group_id #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dottorblaster
previously requested changes
Oct 24, 2022
fabriziosestito
suggested changes
Oct 24, 2022
fabriziosestito
approved these changes
Nov 2, 2022
arbulu89
force-pushed
the
detect-concurrent-execution
branch
2 times, most recently
from
bbea5ee
to
a0ac8d0
Compare
arbulu89
force-pushed
the
detect-concurrent-execution
branch
from
a0ac8d0
to
01d82b7
Compare
arbulu89
dismissed
dottorblaster’s stale review
All the requested changes have been addressesd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detect if an execution with a specific group id is already being executed. Using the
:globalregistry should make this distributed as well. Raise an error in this case by now.We can do different things with this error later on: stop current execution, requeue message...
Some refs on the name registration: https://hexdocs.pm/elixir/1.12/GenServer.html#module-name-registration
PD: Maybe there better solutions for this, but I had some fun learning the :global registry usage hehe