Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: remove unused miss dep #59

Merged
merged 1 commit into from
Oct 18, 2022
Merged

Chore: remove unused miss dep #59

merged 1 commit into from
Oct 18, 2022

Conversation

fabriziosestito
Copy link
Member

We don't use miss anymore

@fabriziosestito fabriziosestito changed the title Remove unused miss dep Chore: remove unused miss dep Oct 18, 2022
arbulu89
arbulu89 reviewed Oct 18, 2022
View reviewed changes
Copy link
Contributor

@arbulu89 arbulu89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this possible? The CI should've caught this

@fabriziosestito
Copy link
Member Author

How is this possible? The CI should've caught this

@arbulu89 the CI checks if we have locked deps that are not in the mix.exs anymore.

@fabriziosestito fabriziosestito merged commit 3f3f8d5 into main Oct 18, 2022
@fabriziosestito fabriziosestito deleted the chore_remove_miss_dep branch October 18, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arbulu89 arbulu89 arbulu89 left review comments

@nelsonkopliku nelsonkopliku nelsonkopliku approved these changes

Assignees
No one assigned
Labels
chore
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fabriziosestito @nelsonkopliku @arbulu89