Rename controllers context #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziosestito
force-pushed
the
rename_controllers_context
branch
from
2a41e87
to
3335c3c
Compare
fabriziosestito
force-pushed
the
rename_controllers_context
branch
from
b521e87
to
0b4c8e9
Compare
fabriziosestito
requested review from
arbulu89,
nelsonkopliku,
dottorblaster and
CDimonaco
dottorblaster
approved these changes
Oct 13, 2022
| %Result{ | ||
| execution_id: execution_id, | ||
| group_id: group_id | ||
| } = result | ||
| ) do | ||
| Wanda.Repo.insert!(%ExecutionResult{ | ||
| Repo.insert!(%ExecutionResult{ |
There was a problem hiding this comment.
Shouldn't have Credo warned us about this?
There was a problem hiding this comment.
Credo warns only if it is nested 2 or 3 levels.
Sometimes it is useful to alias with one level of nesting, for example when you have overlapping module names from different "contexts". This is not the case, tho.
nelsonkopliku
approved these changes
Oct 13, 2022
arbulu89
approved these changes
Oct 13, 2022
| """ | ||
| @spec save_result(Result.t()) :: ExecutionResult.t() | ||
| def save_result( | ||
| @spec create_execution_result(Result.t()) :: ExecutionResult.t() |
There was a problem hiding this comment.
Now the strange this is that we sillt use ExecutionResult
| @@ -13,7 +13,7 @@ | |||
| execution_id = "00000000-0000-0000-0000-000000000001" | |||
| group_id = "00000000-0000-0000-0000-000000000002" | |||
|
|
|||
| Wanda.Results.save_result(%Wanda.Execution.Result{ | |||
| Wanda.Results.create_execution_result(%Wanda.Execution.Result{ | |||
There was a problem hiding this comment.
We should start considering at some point to remove this seed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename controller actions and context to be as close as possible to Phoenix standards, so we can use the
resourcedirective in the router.