Adapted the existing checks to work with ascs_ers cluster #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbulu89
approved these changes
Jul 8, 2024
priv/catalog/6E9B82.yaml
Outdated
| expect: facts.corosync_twonode == values.expected_twonode | ||
| failure_message: Corosync 'two_node' value was expected to be '${values.expected_twonode}' but configured value is '${facts.corosync_twonode}' | ||
| expect: | | ||
| if facts.corosync_num_nodes.len == 2 { facts.corosync_twonode == values.expected_twonode } else if facts.corosync_num_nodes.len >= 3 { facts.corosync_twonode == values.expected_threeormore } |
There was a problem hiding this comment.
Hey @ksanjeet
Here we have a blank sport if for some reason the num of nodes is 1.
Maybe we should add this condition and return false, in the final else statement.
I know it is a corner case, but i don't know how our engine would behave if we don't return a boolean. Most probably the check would fail with a unknown reason.
priv/catalog/D78671.yaml
Outdated
| expect: facts.runtime_two_node == values.expected_runtime_two_node | ||
| failure_message: Corosync 'two_node' value was expected to be '${values.expected_runtime_two_node}' but value of running config is '${facts.runtime_two_node}' | ||
| expect: | | ||
| if facts.corosync_num_nodes.len == 2 { facts.runtime_two_node == values.expected_runtime_two_node } else if facts.corosync_num_nodes.len >= 3 { facts.runtime_two_node == values.expected_runtime_threeormore } |
There was a problem hiding this comment.
I would add a final else here as well.
By the way, the code would looks easier to read if you add some new lines. To look like:
if facts.corosync_num_nodes.len == 2 {
facts.runtime_two_node == values.expected_runtime_two_node
} else if facts.corosync_num_nodes.len >= 3 {
facts.runtime_two_node == values.expected_runtime_threeormore
} else {
false
}
…ondition at the end which results to false
|
Thank you @ksanjeet |
|
Yes, please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapted 3 community checks "6E9B82", "C620DC" and "D78671" to work with ascs_ers cluster. The existing checks had constant values for corosync configurations "two_node" and "expected_vote" which in this adaptation is changed to use conditional checks and depends upon how many nodes are configured in corosync and cib.