Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple checks from being contained in the project #436

Merged
merged 3 commits into from
Aug 19, 2024
Merged

Decouple checks from being contained in the project #436

merged 3 commits into from
Aug 19, 2024

Conversation

dottorblaster
Copy link
Contributor

@dottorblaster dottorblaster commented May 28, 2024 •
edited
Loading

With this PR Wanda becomes able to read whatever path on the filesystem as a source directory for checks.

In tests I specified /opt/trento-checks but we can specify whatever path we see fit for in the config.

@dottorblaster dottorblaster self-assigned this May 28, 2024
@coveralls
Copy link
Collaborator

coveralls commented May 28, 2024 •
edited
Loading

Coverage Status

coverage: 96.861% (+0.2%) from 96.614%
when pulling 7291867 on checks-decoupling
into 2a48dd0 on main.

@dottorblaster dottorblaster force-pushed the checks-decoupling branch 3 times, most recently from b1f08fb to 5022a25 Compare August 13, 2024 12:41
@dottorblaster dottorblaster marked this pull request as ready for review August 13, 2024 12:42
janvhs
janvhs approved these changes Aug 15, 2024
View reviewed changes
Copy link
Member

@janvhs janvhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few open questions from my side. Feel free to ignore the path thing, we can change it as long as we didn't do a release

config/runtime.exs Outdated Show resolved Hide resolved
config/test.exs Outdated Show resolved Hide resolved
@dottorblaster dottorblaster merged commit e5a3b4d into main Aug 19, 2024
14 checks passed
@dottorblaster dottorblaster deleted the checks-decoupling branch August 19, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janvhs janvhs janvhs approved these changes

@jamie-suse jamie-suse jamie-suse approved these changes

@CDimonaco CDimonaco Awaiting requested review from CDimonaco

@balanza balanza Awaiting requested review from balanza

Assignees

@dottorblaster dottorblaster

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dottorblaster @coveralls @jamie-suse @janvhs