Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading Phoenix from 1.6 to 1.7.
Some comments:
phoenix_view
is now a separate package and needs to be added.Phoenix.Router
:(Old arg order in Phoenix 1.6: https://github.com/phoenixframework/phoenix/blob/9da43f0313482ea8eb62e7345cc9b8f18be087ef/lib/phoenix/router.ex#L433
New arg order in Phoenix 1.7.12:
https://github.com/phoenixframework/phoenix/blob/bdc2d7398ac51514d964e02e302515d2ce95b6ff/lib/phoenix/router.ex#L584)
api_redirector
module from a plug to a controller (assuming there is some broad agreement) in order to not have to rely on reflection/non-public interfaces.