Load check values from yaml #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbulu89
force-pushed
the
load-check-value-yaml
branch
from
c599512
to
1dad317
Compare
arbulu89
requested review from
fabriziosestito,
dottorblaster,
nelsonkopliku,
CDimonaco and
rtorrero
fabriziosestito
approved these changes
Oct 6, 2022
nelsonkopliku
approved these changes
Oct 6, 2022
dottorblaster
requested changes
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Load the new
valuesfield from the yaml.PD: I will update the tests using the current check test fixtures in the evaluation UT in a next PR. I want to get rid off them in the evaluation tests and test them properly with factories