Group expectations evaluation #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Carmine Di Monaco <carmine.dimonaco@suse.com>
Co-authored-by: Carmine Di Monaco <carmine.dimonaco@suse.com>
Co-authored-by: Carmine Di Monaco <carmine.dimonaco@suse.com>
fabriziosestito
requested review from
arbulu89,
CDimonaco,
dottorblaster,
EMaksy,
nelsonkopliku and
rtorrero
… logic Co-authored-by: Carmine Di Monaco <carmine.dimonaco@suse.com>
Co-authored-by: Carmine Di Monaco <carmine.dimonaco@suse.com>
Co-authored-by: Carmine Di Monaco <carmine.dimonaco@suse.com>
Co-authored-by: Carmine Di Monaco <carmine.dimonaco@suse.com>
fabriziosestito
force-pushed
the
group_expectations
branch
from
fe7f7a9
to
3b43913
Compare
arbulu89
approved these changes
Aug 3, 2022
There was a problem hiding this comment.
Excellent piece of work @fabriziosestito and @CDimonaco , really fantastic.
The work on the evaluation.ex file is totally great.
I took my time to check the evaluation flow, and even though it is not that simple, with some effort it is easy to understand.
Maybe some docstring explanation above about the general process would help others to understand, something like, but in any case the code is enough meaningful. So don't give to much thought to this hehe
CDimonaco
approved these changes
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the group expectation evaluation and removes the local one.
An expectation declared with
expectis expected to returntrueon all the agents that execute the check.An expectation declare with
expect_sameis expected to returnthe same valueon all the agents that execute the check.It also refactors the shape of the result struct, aggregating the agent evaluations in check results and the check results in an execution result, so we can remove this responsibility from the dashboard.
ATM we provide basic error handling if an expression is invalid or a fact is missing, we will provide more errors in followup PRs and if we add the rustler module for evaluating expressions.