Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable single pipe check on credo #39

Merged
merged 2 commits into from
Oct 3, 2022
Merged

Enable single pipe check on credo #39

merged 2 commits into from
Oct 3, 2022

Conversation

arbulu89
Copy link
Contributor

@arbulu89 arbulu89 commented Oct 3, 2022

Description

Enable SinglePipe check on credo: https://github.com/rrrene/credo/blob/master/lib/credo/check/readability/single_pipe.ex

On @fabriziosestito request XD (as he always forgets hehe)

dottorblaster
dottorblaster approved these changes Oct 3, 2022
View reviewed changes
Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mega LGTM

@fabriziosestito fabriziosestito merged commit 4c2c2dc into main Oct 3, 2022
@fabriziosestito fabriziosestito deleted the credo-enable-single-pipe branch October 3, 2022 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nelsonkopliku nelsonkopliku nelsonkopliku approved these changes

@dottorblaster dottorblaster dottorblaster approved these changes

@fabriziosestito fabriziosestito Awaiting requested review from fabriziosestito

@CDimonaco CDimonaco Awaiting requested review from CDimonaco

@rtorrero rtorrero Awaiting requested review from rtorrero

Assignees
No one assigned
Labels
tech-debt
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arbulu89 @dottorblaster @nelsonkopliku @fabriziosestito