Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check 61451E - check for consecutive semicolons (jsc#TRNT-2015) #382

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

angelabriel
Copy link
Contributor

check using the new expect_enum
If we detect consecutive semicolons, we return critical.
If we detect less or more than 3 SBD devices, we return warning.
Everything else for now is passing.

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 95.045%. remained the same
when pulling 50e3391 on angelabriel:SBD
into 979919a on trento-project:main.

@dottorblaster
Copy link
Contributor

@angelabriel is this fine to merge?

@angelabriel
Copy link
Contributor Author

@dottorblaster yes, fine for me. Thanks for the review

@dottorblaster
Copy link
Contributor

Great!

@dottorblaster dottorblaster merged commit 1dcb3df into trento-project:main Mar 19, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

4 participants