Some needed improvements to make the code runnable on prod environment #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbulu89
requested review from
fabriziosestito,
nelsonkopliku and
CDimonaco
nelsonkopliku
approved these changes
Sep 30, 2022
rtorrero
reviewed
Sep 30, 2022
arbulu89
force-pushed
the
prod-ready-code
branch
4 times, most recently
from
b91e14e
to
c1395a3
Compare
|
Hey @fabriziosestito , |
arbulu89
force-pushed
the
prod-ready-code
branch
from
c1395a3
to
92e9766
Compare
LGTM |
fabriziosestito
approved these changes
Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the amqp url configurable on runtime and update how the catalog path is obtained.
This 2nd thing is needed to run the code in our docker file, as we don't copy the whole release files. We would need to copy the
/build/_build/prod/lib/wanda/priv/folder as it is, with that exact path. The old@catalog_pathwas build on compilation time, which is less flexible. (Most probably there is some better way for doing this properly hehe)