Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a storable Wanda.Result.ExecutionResult entity #35

Merged
merged 3 commits into from
Sep 29, 2022

Conversation

nelsonkopliku
Copy link
Member

@nelsonkopliku nelsonkopliku commented Sep 28, 2022

Description

This pr adds a Wanda.Result.ExecutionResult entity storable on the database.
This entity is as simple as containing:

  • an execution_id
  • a group_id
  • a payload with the whole content of a Wanda.Result.ExecutionResult

image

image

this entity in upcoming PRs would:

  • be stored when an execution completed
  • read and exposed in the list API
  • read and exposed in the detail API

How was this tested?

At the moment manually by running a mix ecto.setup or a mix ecto.reset.
By doing so we should have one record in the database.

image

Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but see the comments

priv/repo/seeds.exs Outdated Show resolved Hide resolved
@nelsonkopliku nelsonkopliku force-pushed the add_execution_result_entity branch 2 times, most recently from 2cc13d4 to e38c71b Compare September 28, 2022 16:56
@nelsonkopliku nelsonkopliku merged commit 88d2ecf into main Sep 29, 2022
@fabriziosestito fabriziosestito deleted the add_execution_result_entity branch November 17, 2022 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

5 participants