Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix redirection when a query string is involved #330

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

nelsonkopliku
Copy link
Member

@nelsonkopliku nelsonkopliku commented Oct 24, 2023

Description

Fixes redirection when also a query string is involved in the initial request.
Needs to go after #326

How was this tested?

Automated test added.

@nelsonkopliku nelsonkopliku self-assigned this Oct 24, 2023
@nelsonkopliku nelsonkopliku added the bug Something isn't working label Oct 24, 2023
@github-actions
Copy link

github-actions bot commented Oct 24, 2023

Coverage Status

coverage: 95.19% (+0.03%) from 95.165% when pulling 43dcc9a on fix-redirection-with-qs into b633138 on main.

Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small thing but the content is absolutely legit 👍

Once rebased, we can merge

lib/wanda_web/plugs/api_redirector.ex Outdated Show resolved Hide resolved
@nelsonkopliku nelsonkopliku merged commit e57393e into main Oct 25, 2023
13 checks passed
@nelsonkopliku nelsonkopliku deleted the fix-redirection-with-qs branch October 25, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

2 participants