Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disp work gatherer docs #323

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Disp work gatherer docs #323

merged 1 commit into from
Oct 24, 2023

Conversation

arbulu89
Copy link
Contributor

Docs for the disp+work gatherer:
trento-project/agent#281

@arbulu89 arbulu89 marked this pull request as ready for review October 23, 2023 07:25
@github-actions
Copy link

Coverage Status

coverage: 95.128%. remained the same when pulling 6a5851d on disp-work-gatherer-docs into 20ed8c8 on main.

| [`fstab`](#fstab) | [trento-project/agent/../gatherers/fstab.go](https://github.com/trento-project/agent/blob/main/internal/factsengine/gatherers/fstab.go) |
| [`groups`](#groups) | [trento-project/agent/../gatherers/groups.go](https://github.com/trento-project/agent/blob/main/internal/factsengine/gatherers/groups.go) |
| [`hosts`](#hosts-etchosts) | [trento-project/agent/../gatherers/hostsfile.go](https://github.com/trento-project/agent/blob/main/internal/factsengine/gatherers/hostsfile.go) |
| [`package_version`](#package_version) | [trento-project/agent/../gatherers/packageversion.go](https://github.com/trento-project/agent/blob/main/internal/factsengine/gatherers/packageversion.go) |
| [`passwd`](#passwd) | [trento-project/agent/../gatherers/passwd.go](https://github.com/trento-project/agent/blob/main/internal/factsengine/gatherers/passwd.go) |
| [`sapcontrol`](#sapcontrol) | [trento-project/agent/../gatherers/sapcontrol.go](https://github.com/trento-project/agent/blob/main/internal/factsengine/gatherers/sapcontrol.go) |
| [`saphostctrl`](#saphostctrl) | [trento-project/agent/../gatherers/saphostctrl.go](https://github.com/trento-project/agent/blob/main/internal/factsengine/gatherers/saphostctrl.go) |
| [`saphostctrl`](#saphostctrl) | [trento-project/agent/../gatherers/saphostctrl.go](https://github.com/trento-project/agent/blob/main/inAternal/factsengine/gatherers/saphostctrl.go) |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in the link
inAternalshould be internal right?

Copy link
Member

@EMaksy EMaksy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey man besides the typo/broken link nothing to add, well done :D

Copy link
Member

@EMaksy EMaksy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :D

@arbulu89 arbulu89 added the documentation Improvements or additions to documentation label Oct 23, 2023
Copy link
Contributor

@rtorrero rtorrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arbulu89 arbulu89 force-pushed the disp-work-gatherer-docs branch 2 times, most recently from 1abf669 to ba03f04 Compare October 24, 2023 11:58
@github-actions
Copy link

Coverage Status

coverage: 95.128%. remained the same when pulling ba03f04 on disp-work-gatherer-docs into 0001060 on main.

@arbulu89 arbulu89 merged commit f31eef0 into main Oct 24, 2023
12 checks passed
@arbulu89 arbulu89 deleted the disp-work-gatherer-docs branch October 24, 2023 12:05
@CDimonaco CDimonaco added the enhancement New feature or request label Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

4 participants