Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update checks definition schema #312

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Update checks definition schema #312

merged 1 commit into from
Oct 11, 2023

Conversation

nelsonkopliku
Copy link
Member

@nelsonkopliku nelsonkopliku commented Oct 10, 2023 •
edited
Loading

Updating check schema definition to support metadata

https://www.jsonschemavalidator.net/s/OWun3aGl

@github-actions
Copy link

Coverage Status

coverage: 96.226%. remained the same when pulling 761e418 on update-check-definition-schema into 358a0b8 on main.

@nelsonkopliku nelsonkopliku marked this pull request as ready for review October 10, 2023 13:46
@nelsonkopliku nelsonkopliku self-assigned this Oct 10, 2023
@nelsonkopliku nelsonkopliku added enhancement New feature or request check labels Oct 10, 2023
dottorblaster
dottorblaster approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nelsonkopliku nelsonkopliku merged commit 1111d50 into main Oct 11, 2023
12 checks passed
@nelsonkopliku nelsonkopliku deleted the update-check-definition-schema branch October 11, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamie-suse jamie-suse jamie-suse approved these changes

@dottorblaster dottorblaster dottorblaster approved these changes

Assignees

@nelsonkopliku nelsonkopliku

Labels
check enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nelsonkopliku @dottorblaster @jamie-suse