Refactor execution pt1 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziosestito
force-pushed
the
refactor_execution_pt1
branch
2 times, most recently
from
3745d00
to
cf25d5f
Compare
Co-authored-by: Carmine Di Monaco <carmine.dimonaco@suse.com>
Co-authored-by: Carmine Di Monaco <carmine.dimonaco@suse.com>
Co-authored-by: Carmine Di Monaco <carmine.dimonaco@suse.com>
Co-authored-by: Carmine Di Monaco <carmine.dimonaco@suse.com>
Co-authored-by: Carmine Di Monaco <carmine.dimonaco@suse.com>
Co-authored-by: Carmine Di Monaco <carmine.dimonaco@suse.com>
Co-authored-by: Carmine Di Monaco <carmine.dimonaco@suse.com>
Co-authored-by: Carmine Di Monaco <carmine.dimonaco@suse.com>
fabriziosestito
force-pushed
the
refactor_execution_pt1
branch
from
cf25d5f
to
76f6a12
Compare
fabriziosestito
requested review from
nelsonkopliku,
arbulu89,
CDimonaco,
dottorblaster,
rtorrero and
stefanotorresi
fabriziosestito
force-pushed
the
refactor_execution_pt1
branch
from
31ae760
to
b7418a8
Compare
fabriziosestito
force-pushed
the
refactor_execution_pt1
branch
from
b7418a8
to
818abb7
Compare
arbulu89
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the execution GenServer, separating the functional core from the side effects.
It adds tests and the concept of the result of execution.
Next PRs will add grouped expectations and rabbit messaging.