Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document cluster type support #248

Merged
merged 2 commits into from
Jun 6, 2023
Merged

Document cluster type support #248

merged 2 commits into from
Jun 6, 2023

Conversation

arbulu89
Copy link
Contributor

@arbulu89 arbulu89 commented Jun 1, 2023

Document cluster_type env variable support.

Besides that, I have fixed a corner case issue, if some day we decide to send a null value in an env entry (unlikely, but hey, it won't break hehe)

@arbulu89 arbulu89 force-pushed the document-cluster-type-support branch 2 times, most recently from f185a29 to 5a6d716 Compare June 1, 2023 14:08
@arbulu89 arbulu89 added the documentation Improvements or additions to documentation label Jun 1, 2023
abravosuse
abravosuse approved these changes Jun 1, 2023
View reviewed changes
Copy link

@abravosuse abravosuse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@coveralls
Copy link
Collaborator

coveralls commented Jun 1, 2023 •
edited by github-actions bot
Loading

Coverage Status

coverage: 96.1% (+0.02%) from 96.078% when pulling d0a46b7 on document-cluster-type-support into d9acee3 on main.

@arbulu89 arbulu89 force-pushed the document-cluster-type-support branch from 5a6d716 to 489ded8 Compare June 1, 2023 14:25
@arbulu89 arbulu89 force-pushed the document-cluster-type-support branch from 489ded8 to d0a46b7 Compare June 1, 2023 14:28
@arbulu89 arbulu89 marked this pull request as ready for review June 1, 2023 14:29
dottorblaster
dottorblaster approved these changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fabriziosestito fabriziosestito merged commit f4dd51e into main Jun 6, 2023
@fabriziosestito fabriziosestito deleted the document-cluster-type-support branch June 6, 2023 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abravosuse abravosuse abravosuse approved these changes

@CDimonaco CDimonaco CDimonaco approved these changes

@nelsonkopliku nelsonkopliku nelsonkopliku approved these changes

@fabriziosestito fabriziosestito fabriziosestito approved these changes

@dottorblaster dottorblaster dottorblaster approved these changes

@rtorrero rtorrero Awaiting requested review from rtorrero

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@arbulu89 @coveralls @dottorblaster @fabriziosestito @nelsonkopliku @CDimonaco @abravosuse