Improve gatherers documentation and add rhai example outputs #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziosestito
force-pushed
the
add_gatherer_output_examples
branch
from
7b6d2a4
to
e7d1ca4
Compare
fabriziosestito
changed the title
fabriziosestito
requested review from
nelsonkopliku,
dottorblaster and
rtorrero
nelsonkopliku
requested changes
Jan 16, 2023
arbulu89
requested changes
Jan 16, 2023
| | :------------------------------------------------------------- | :----------------------------------------------------------------- | | ||
| | `cib.configuration` | complete cib configuration entry as a map | | ||
| | `cib.configuration.resources.primitive.0` | first available primitive resource | | ||
| | `cib.configuration.crm_config.cluster_property_set.0.nvpair.1` | second nvpair value from the first element of cluster_property_set | |
There was a problem hiding this comment.
If the cluster_property_set is a potential list, we will need to include it here:
https://github.com/trento-project/agent/blob/main/internal/factsengine/gatherers/cibadmin.go#L48
| Sample arguments: | ||
| | Name | Return value | | ||
| | :--------------------------- | :------------------------------- | | ||
| | `totem.token` | extracted value from the command | |
There was a problem hiding this comment.
Now that we have the new implementation of this gatherer done, we should include new examples. @jamie-suse could you do that in an additional PR?
There was a problem hiding this comment.
Yep @arbulu89, I can add examples featuring an output that contains a list.
rtorrero
reviewed
Jan 16, 2023
fabriziosestito
force-pushed
the
add_gatherer_output_examples
branch
2 times, most recently
from
62ae5d3
to
28577f7
Compare
arbulu89
approved these changes
Jan 16, 2023
fabriziosestito
force-pushed
the
add_gatherer_output_examples
branch
from
28577f7
to
b626af3
Compare
rtorrero
approved these changes
Jan 16, 2023
fabriziosestito
force-pushed
the
add_gatherer_output_examples
branch
from
b626af3
to
2754d78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves gatherers documentation, spellcheck, and format and adds rhai example outputs in place of golang test links.