This repository was archived by the owner on May 30, 2022. It is now read-only.
Fix tag removal when filtering #733
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbulu89
requested review from
dottorblaster,
fabriziosestito,
rtorrero,
stefanotorresi and
nelsonkopliku
arbulu89
force-pushed
the
hotfix/fix-tag-removal-when-filtering
branch
4 times, most recently
from
504a554 to
87a5595
Compare
arbulu89
force-pushed
the
hotfix/fix-tag-removal-when-filtering
branch
from
87a5595 to
6ff857a
Compare
|
Finally, the e2e test added in this PR works 100% of the times. I just needed to add many intercepts as the tags select element gets rendered every time a new tag is added, re-created the DOM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for: #478
