Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve flaky test harness tests in command and integration suites #2482

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

darach
Copy link
Member

@darach darach commented Apr 12, 2024

Description

Small fixes to file based assertions ( adds is_empty, is_not_empty predicates ) and
fixes to elastic-verify-gd to resolve assertion failures when running the test harness
in CI mode.

Checklist

No change to production / critical code.

Performance

No impact

Note

This is in part a hedge to remove any potential impact to flaky CI coverage runs. No freezes, hangs or
odd stalls when running locally as follows:

cargo llvm-cov run --lcov --output-path integration_lcov.txt -- test --timeout 300 integration tremor-cli/tests --report integration.json 
cargo llvm-cov run --lcov --output-path command_lcov.txt -- test --timeout 300 command tremor-cli/tests --report command.json 
cargo llvm-cov run --lcov --output-path unit_lcov.txt -- test --timeout 300 unit tremor-cli/tests --report unit.json 

The mystery deepens!

Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.76%. Comparing base (c0b8360) to head (0688fe5).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2482      +/-   ##
==========================================
+ Coverage   82.93%   90.76%   +7.82%     
==========================================
  Files         299      299              
  Lines       57157    58877    +1720     
==========================================
+ Hits        47404    53438    +6034     
+ Misses       9753     5439    -4314     
Flag Coverage Δ
e2e-command 11.50% <ø> (ø)
e2e-integration 51.52% <ø> (+0.18%) ⬆️
e2e-unit 12.75% <ø> (ø)
e2etests 53.93% <ø> (+0.18%) ⬆️
tremorapi 14.63% <ø> (ø)
tremorcodec 63.82% <ø> (ø)
tremorcommon 57.57% <ø> (ø)
tremorconnectors 27.38% <ø> (?)
tremorconnectorsaws 11.13% <ø> (ø)
tremorconnectorsgcp 20.48% <ø> (-0.15%) ⬇️
tremorconnectorsobjectstorage 0.00% <ø> (ø)
tremorconnectorsotel 12.76% <ø> (ø)
tremorconnectorstesthelpers 60.56% <ø> (ø)
tremorinflux 87.72% <ø> (ø)
tremorinterceptor 52.74% <ø> (ø)
tremorpipeline 30.74% <ø> (ø)
tremorruntime 47.84% <ø> (?)
tremorscript 54.11% <ø> (ø)
tremorsystem 5.37% <ø> (ø)
tremorvalue 72.45% <ø> (ø)
unittests 87.98% <ø> (+19.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 97 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0b8360...0688fe5. Read the comment docs.

@@ -345,6 +348,8 @@ pub(crate) fn process_filebased_asserts(
contains: None,
doesnt_contain: None,
equals_file: None,
is_empty: None,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is_empty and is_not_empty seem to be the same just inverted. It looks like they can be reduced to a single flag, halfing the needed code and preventing possible confusion.

@Licenser Licenser force-pushed the fix-flaky-tremorcli-tests branch 2 times, most recently from c1d7971 to 8fbf62d Compare April 22, 2024 11:12
Signed-off-by: Darach Ennis <darach@gmail.com>
contains:
- |
{"action":"index","correlation":"baz","index":"my_little_index","payload":{"action":null,"cause":"this one has a different type underneath the same key and thus will fail elastic","snot":"baz","tremor":12},"success":false}
- source: ok.log
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be a single contains with multiple elements? (same for error.log)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants