-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve flaky test harness tests in command and integration suites #2482
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2482 +/- ##
==========================================
+ Coverage 82.93% 90.76% +7.82%
==========================================
Files 299 299
Lines 57157 58877 +1720
==========================================
+ Hits 47404 53438 +6034
+ Misses 9753 5439 -4314
Flags with carried forward coverage won't be shown. Click here to find out more. see 97 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
@@ -345,6 +348,8 @@ pub(crate) fn process_filebased_asserts( | |||
contains: None, | |||
doesnt_contain: None, | |||
equals_file: None, | |||
is_empty: None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is_empty and is_not_empty seem to be the same just inverted. It looks like they can be reduced to a single flag, halfing the needed code and preventing possible confusion.
c1d7971
to
8fbf62d
Compare
Signed-off-by: Darach Ennis <darach@gmail.com>
8fbf62d
to
0688fe5
Compare
contains: | ||
- | | ||
{"action":"index","correlation":"baz","index":"my_little_index","payload":{"action":null,"cause":"this one has a different type underneath the same key and thus will fail elastic","snot":"baz","tremor":12},"success":false} | ||
- source: ok.log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this be a single contains with multiple elements? (same for error.log)
Description
Small fixes to file based assertions ( adds is_empty, is_not_empty predicates ) and
fixes to
elastic-verify-gd
to resolve assertion failures when running the test harnessin CI mode.
Checklist
No change to production / critical code.
Performance
No impact
Note
This is in part a hedge to remove any potential impact to flaky CI coverage runs. No freezes, hangs or
odd stalls when running locally as follows:
The mystery deepens!