Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add avro codec #2343

Merged
merged 3 commits into from
Aug 15, 2023
Merged

Add avro codec #2343

merged 3 commits into from
Aug 15, 2023

Conversation

Licenser
Copy link
Member

Pull request

Description

A simple encoder and decoder of the apache avro binary codec

Related

Checklist

  • The RFC, if required, has been submitted and approved
  • Any user-facing impact of the changes is reflected in docs.tremor.rs
  • The code is tested
  • Use of unsafe code is reasoned about in a comment
  • Update CHANGELOG.md appropriately, recording any changes, bug fixes, or other observable changes in behavior
  • The performance impact of the change is measured (see below)

Performance

-/-

Signed-off-by: Heinz N. Gies <heinz@licenser.net>
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #2343 (41b4f22) into main (20c76b7) will decrease coverage by 0.07%.
The diff coverage is 82.05%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2343      +/-   ##
==========================================
- Coverage   91.09%   91.03%   -0.07%     
==========================================
  Files         274      275       +1     
  Lines       58233    58649     +416     
==========================================
+ Hits        53048    53390     +342     
- Misses       5185     5259      +74     
Flag Coverage Δ
unittests 91.03% <82.05%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
tremor-value/src/error.rs 71.42% <0.00%> (-3.58%) ⬇️
tremor-value/src/value.rs 98.92% <66.66%> (-0.18%) ⬇️
src/codec/avro.rs 82.30% <82.30%> (ø)
src/codec.rs 85.71% <100.00%> (+0.23%) ⬆️
src/errors.rs 84.35% <100.00%> (+0.03%) ⬆️
tremor-value/src/serde/value/de.rs 78.71% <100.00%> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20c76b7...41b4f22. Read the comment docs.

Signed-off-by: Heinz N. Gies <heinz@licenser.net>
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
Copy link
Member

@darach darach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@Licenser Licenser merged commit bfe12a7 into main Aug 15, 2023
18 checks passed
@Licenser Licenser deleted the avro-codec branch August 15, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add avro codec
2 participants