Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shrink large functions #20

Open
Licenser opened this issue Dec 12, 2019 · 2 comments
Open

Shrink large functions #20

Licenser opened this issue Dec 12, 2019 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed

Comments

@Licenser
Copy link
Member

We have a number of functions that are marked as clippy::too_many_lines - it would be good to go over them and see if they can be cut down into easier to understand functions.
@Licenser Licenser added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Dec 12, 2019
@0xdeafbeef
Copy link
Contributor

Nothing is found with clippy. Everything is refactored?

@anupdhml
Copy link
Contributor

anupdhml commented May 6, 2020

@0xd34b33f there's quite a few of them still: https://github.com/wayfair-tremor/tremor-runtime/search?q=too_many_lines&unscoped_q=too_many_lines

We have clippy exceptions for them right now so they don't show up with clippy.

If you are interested in refactoring them, feel free to take this!

MordecaiMalignatus added a commit to MordecaiMalignatus/tremor-runtime that referenced this issue Oct 28, 2021
@MordecaiMalignatus
tremor-cli/test: Refactor large parts of the test code.
b1558f2 
This gets rid of one of the long functions mentioned in tremor-rs#20, makes the code more
readable, and (in the future) easier to test properly.
@MordecaiMalignatus MordecaiMalignatus mentioned this issue Oct 28, 2021
Closed
4 tasks
MordecaiMalignatus added a commit to MordecaiMalignatus/tremor-runtime that referenced this issue Oct 28, 2021
@MordecaiMalignatus
tremor-cli/test: Refactor large parts of the test code.
085afb9 
This gets rid of one of the long functions mentioned in tremor-rs#20, makes the code more
readable, and (in the future) easier to test properly.

Signed-off-by: Mordecai Malignatus <mordecai@malignat.us>
MordecaiMalignatus added a commit to MordecaiMalignatus/tremor-runtime that referenced this issue Oct 28, 2021
@MordecaiMalignatus
tremor-cli/test: Refactor large parts of the test code.
bf092d0 
This gets rid of one of the long functions mentioned in tremor-rs#20, makes the code more
readable, and (in the future) easier to test properly.

Signed-off-by: Mordecai Malignatus <mordecai@malignat.us>
MordecaiMalignatus added a commit to MordecaiMalignatus/tremor-runtime that referenced this issue Oct 28, 2021
@MordecaiMalignatus
tremor-cli/test: Refactor large parts of the test code.
9bb8ccd 
This gets rid of one of the long functions mentioned in tremor-rs#20, makes the code more
readable, and (in the future) easier to test properly.

Signed-off-by: Mordecai Malignatus <mordecai@malignat.us>
MordecaiMalignatus added a commit to MordecaiMalignatus/tremor-runtime that referenced this issue Oct 28, 2021
@MordecaiMalignatus
tremor-cli/test: Refactor large parts of the test code.
959afe4 
This gets rid of one of the long functions mentioned in tremor-rs#20, makes the code more
readable, and (in the future) easier to test properly.

Signed-off-by: Mordecai Malignatus <mordecai@malignat.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Licenser @darach @anupdhml @0xdeafbeef