HTTPS on URL link #5
Conversation
|
See #4 |
| @@ -73,7 +73,7 @@ while [ $# -gt 0 ]; do | |||
| url="${url%%</link>*}" | |||
| delete_hash="${response##*<deletehash>}" | |||
| delete_hash="${delete_hash%%</deletehash>*}" | |||
| echo $url | |||
| echo $url | sed 's/^http/https/' | |||
There was a problem hiding this comment.
If you just add a colon to the end of this I'll merge it; s/^http:/https:/. I know it likely doesn't ever make any practical difference but I like to be sure.
|
Great; squash the commits into one, please. |
|
In case you don't know how, |
|
That should be it, yeah I'm familiar with commit squashing, just don't tend to take a strong stance on it myself! Let me know if you'd like anything else, and thanks for the PR, I appreciate it 😘 |
|
Thanks! Hopefully upstream return https as well eventually. |
|
The code as you've written it won't mind either way, which is good. |
No description provided.