Do not mutate plot props when zooming #5066
Conversation
![qlty-cloud-legacy[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| ) : ( | ||
| <VegaLite {...plotProps} onNewView={onNewView} /> | ||
| ))} | ||
| {isTemplatePlot ? ( |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
There was a problem hiding this comment.
Using the full Vega API for signals and views (https://vega.github.io/vega/docs/api/view/#signals) to make things simpler
|
Code Climate has analyzed commit ec37342 and detected 3 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.3% (0.0% change). View more on Code Climate. |
| }, [dispatch, wrapperRef]) | ||
|
|
||
| if (!hasData) { | ||
| return <EmptyState>Loading Plots...</EmptyState> |
There was a problem hiding this comment.
Not quite sure what is going on, but when I tested the smooth plots, the plots started behaving really weird:
Screen.Recording.2023-12-05.at.9.46.02.AM.mov
I doubled checked to make sure it wasn't happening on main and main is working correctly.
|
Dependency management between Studio/VS Code/DVC has turned out to be a bit more complicated than I thought it was going to be. To merge #4734 and roll out the rest of the plots PRs I am going to have to:
I'm going to pull the rug on this PR. Sorry. |
No worries. I think you already did the same thing or similar in your PR. For using the Vega API, it's easy to re-add later. |
3 participants
Fixes the root cause of #4671
Demo:
Screen.Recording.2023-12-04.at.2.52.08.PM.mov
We previously fixed the bug when closing the section by working around the bug as we did in the past as well.
The bug was also seen when drag and dropping without changes and would have happened on every component restore.
The fix here is to not pass the props to the zoomed in props, but get them from there.
The changes inside
TemplateVegaLitehelped in finding out where the bug was and make things cleaner in general.