Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Group's and Policy's search functionality in webUI #8783

Merged
merged 2 commits into from
Mar 13, 2025

Conversation

Annaseli
Copy link
Contributor

@Annaseli Annaseli commented Mar 10, 2025

Change Description

Background

Previously, there was no way to search for Groups and Policies in the Administration tab of the web UI.

New Feature

This PR introduces a search box in the Groups and Policies tabs in the Administration section of the web UI.

Functionality:

  1. Prefix Search – The search box performs a prefix search on the user’s input, returning all groups and policies whose names start with the given prefix.
  2. API Prefix Search – The search utilizes the prefix parameter in the API call to retrieve only the filtered results.
  3. Case-Sensitive – The search is case-sensitive, meaning it distinguishes between uppercase and lowercase letters.
  4. Real-Time Search – The user does not need to press "Enter" to submit the input; results appear immediately as they type.
  5. Debounced API Calls – To optimize performance, API requests are debounced by 300ms, reducing unnecessary calls.
  6. Supports Pagination – If the search results exceed the default page size, they are displayed in pages, maintaining the prefix filter.
  7. Search Persistence After Refresh – After a page refresh, the previous search prefix remains applied, with an indicator showing the last input.

Limitations:
If no results match the search, an empty window is displayed, similar to the Repository search behavior.

Screenshots:
image
image
image
image

Testing Details

Tested with Fluffy and lakeFS OSS locally.

@Annaseli Annaseli added area/UI Improvements or additions to UI include-changelog PR description should be included in next release changelog labels Mar 10, 2025
@Annaseli Annaseli requested a review from guy-har March 10, 2025 12:25
Copy link

E2E Test Results - DynamoDB Local - Local Block Adapter

14 passed

Copy link

E2E Test Results - Quickstart

11 passed

@Annaseli Annaseli added the minor-change Used for PRs that don't require issue attached label Mar 10, 2025
@Annaseli Annaseli requested a review from a team March 10, 2025 14:07
Copy link
Contributor

@itaigilo itaigilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Annaseli , this looks great!

Requesting changes only for a minor simplification, and make sure nothing is missed there.

@Annaseli Annaseli requested a review from itaigilo March 12, 2025 11:43
Copy link
Contributor

@itaigilo itaigilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! 🎉

Approving,
And adding a bunch of nit suggestions, on the same issue (your choice if you want to add it).

@Annaseli
Copy link
Contributor Author

Looking great! 🎉

Approving, And adding a bunch of nit suggestions, on the same issue (your choice if you want to add it).

Added your suggestions :)

@Annaseli Annaseli merged commit 09f8bbd into master Mar 13, 2025
42 checks passed
@Annaseli Annaseli deleted the feature/search-in-groups-and-policies-668 branch March 13, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/UI Improvements or additions to UI include-changelog PR description should be included in next release changelog minor-change Used for PRs that don't require issue attached
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants