-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Web UI Merge Dialog Enter Should Submit #8781
Conversation
Compare two branches, enabling the "Merge" button. Upon merging, a dialog popup appears requesting a commit message and related information. **Currently**, pressing enter after entering the merge commit message triggers the "Cancel" operation instead of the default "Merge" action.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, requesting changes for the Issue here (and not the PR):
Merge sounds like something to be considered carefully by the users.
I think that the friction added by having to click and not simply press Enter
is better in this case.
What is the origin of this requirement? Is it something coming from users?
Maybe it's worth removing the Cancel-on-Enter behavior instead?
It came from frustration while working with UI and getting different experience from command and merge using the keyboard.
The above aligned to commit, but if you think we should change both and require key combo to apply the change - I'm very open. |
@itaigilo also not that usually in the UX the green button is the default, but I agree that in some dialogs, usually multi-line text, the enter will not trigger the button. |
@nopcoder my thoughts on this:
|
@itaigilo as merge and commit both modify the branch by adding a commit (both we can revert) I will go with align the Enter for both commit and merge operations. |
New code was tested manually by performing a Merge operation between branches.
Closes #8780