Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go packages with required code #6785

Merged
merged 2 commits into from
Oct 15, 2023
Merged

Conversation

nopcoder
Copy link
Contributor

@nopcoder nopcoder commented Oct 13, 2023

Updates the following packages:

cloud.google.com/go/storage: v1.28.1 [latest v1.33.0]
github.com/Azure/azure-sdk-for-go/sdk/azcore: v1.4.0 [latest v1.8.0]
github.com/Azure/azure-sdk-for-go/sdk/azidentity: v1.1.0 [latest v1.4.0]
github.com/Azure/azure-sdk-for-go/sdk/data/azcosmos: v0.3.5 [latest v0.3.6]
github.com/Azure/azure-sdk-for-go/sdk/storage/azblob: v0.6.1 [latest v1.2.0]
github.com/alitto/pond: v1.8.2 [latest v1.8.3]
github.com/antonmedv/expr: v1.12.5 [latest v1.15.3]
github.com/apache/thrift: v0.14.1 [latest v0.19.0]
github.com/aws/aws-sdk-go: v1.43.31 [latest v1.45.25]
github.com/aws/aws-sdk-go-v2: v1.21.0 [latest v1.21.2]
github.com/aws/aws-sdk-go-v2/config: v1.18.36 [latest v1.18.45]
github.com/aws/aws-sdk-go-v2/credentials: v1.13.35 [latest v1.13.43]
github.com/aws/aws-sdk-go-v2/feature/dynamodb/attributevalue: v1.10.39 [latest v1.10.42]
github.com/aws/aws-sdk-go-v2/feature/dynamodb/expression: v1.4.66 [latest v1.4.69]
github.com/aws/aws-sdk-go-v2/feature/s3/manager: v1.11.80 [latest v1.11.90]
github.com/aws/aws-sdk-go-v2/service/dynamodb: v1.21.5 [latest v1.22.2]
github.com/aws/aws-sdk-go-v2/service/glue: v1.61.2 [latest v1.63.0]
github.com/aws/aws-sdk-go-v2/service/s3: v1.38.5 [latest v1.40.2]
github.com/aws/aws-sdk-go-v2/service/sts: v1.21.5 [latest v1.23.2]
github.com/aws/smithy-go: v1.14.2 [latest v1.15.0]
github.com/go-chi/chi/v5: v5.0.0 [latest v5.0.10]
github.com/go-co-op/gocron: v1.18.0 [latest v1.35.2]
github.com/go-test/deep: v1.0.7 [latest v1.1.0]
github.com/google/uuid: v1.3.0 [latest v1.3.1]
github.com/hashicorp/go-hclog: v1.2.0 [latest v1.5.0]
github.com/hashicorp/go-retryablehttp: v0.7.2 [latest v0.7.4]
github.com/jackc/pgx/v5: v5.3.1 [latest v5.4.3]
github.com/jedib0t/go-pretty/v6: v6.2.4 [latest v6.4.8]
github.com/manifoldco/promptui: v0.8.0 [latest v0.9.0]
github.com/minio/minio-go/v7: v7.0.34 [latest v7.0.63]
github.com/rs/xid: v1.4.0 [latest v1.5.0]
github.com/prometheus/client_golang: v1.16.0 [latest v1.17.0]
github.com/spf13/viper: v1.16.0 [latest v1.17.0]
github.com/thanhpk/randstr: v1.0.4 [latest v1.0.6]
github.com/tsenart/vegeta/v12: v12.8.4 [latest v12.11.1]
github.com/xitongsys/parquet-go: v1.6.0 [latest v1.6.2]
go.uber.org/ratelimit: v0.2.0 [latest v0.3.0]
golang.org/x/crypto: v0.11.0 [latest v0.14.0]
golang.org/x/net: v0.12.0 [latest v0.17.0]
golang.org/x/oauth2: v0.8.0 [latest v0.13.0]
golang.org/x/sync: v0.3.0 [latest v0.4.0]
golang.org/x/term: v0.10.0 [latest v0.13.0]
google.golang.org/api: v0.122.0 [latest v0.147.0]
google.golang.org/grpc: v1.55.0 [latest v1.58.3]

S3 Config Test

Update test to fail in case we configure aws with unknown profile

Azure Blob

The github.com/Azure/azure-sdk-for-go/sdk/storage/azblob had major upgrade. https://azure.github.io/azure-sdk/releases/2023-02/go.html
It required code changes:

  • StageBlockFromURL - doesn't accept count, seems that previously it was content-length
  • GetSASURL - argument order changed
  • Update field member names like Go like
    Also the emulator azure-storage/azurite to the latest version 3.26.0 - we should consider pulling always the latest as it represents the azure service.

Thrift

Update the thrift package and generator

  • Found missing field ID - fixed
  • Updated the transport initialize - api change
  • Saved the new generated code

Close #6786

@nopcoder nopcoder self-assigned this Oct 13, 2023
@nopcoder nopcoder added the include-changelog PR description should be included in next release changelog label Oct 13, 2023
@nopcoder nopcoder requested a review from a team October 15, 2023 05:27
Copy link
Contributor

@arielshaqed arielshaqed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

  1. Why did we do this (now)?
  2. Can you please add the command that you used to update the dependencies, so that we have a reference for the next time we do this? (I understand of course that the post-update code changes were necessary and manual, I'm talking about steps to update go.mod.)

@nopcoder
Copy link
Contributor Author

Good idea!

  1. Why did we do this (now)?
  2. Can you please add the command that you used to update the dependencies, so that we have a reference for the next time we do this? (I understand of course that the post-update code changes were necessary and manual, I'm talking about steps to update go.mod.)
  1. Other work trigger the fact that we use deprecated version of packages. Looking on cargo made me look into our diff plugin, which had me look into the protoc generated code, which got me to the fact that we use old google package (also for the generated code). Checking the list of packages that required update, found that there are many fixes that we lack. Also my concern was with the cloud providers SDK that recommends to update the client side as a saas service. Note I didn't upgrade all the packages in the project, and I tried to avoid major versions unless it was related to package that is used by cloud provider or test.
  2. Used https://github.com/icholy/gomajor to get the nice report (there should be a simple go command that lists the outdated packages). The above list is just the packages I've updated. The update was done using go get <package name without tag> to get the latest for the specific package. After update the specific packages I had to go mod tidy.

@nopcoder nopcoder requested a review from N-o-Z October 15, 2023 07:44
Copy link
Member

@N-o-Z N-o-Z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the Azure changes - LGTM!

@nopcoder nopcoder merged commit ca1cd65 into master Oct 15, 2023
@nopcoder nopcoder deleted the chore/update-dep-packages branch October 15, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include-changelog PR description should be included in next release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update packages used by lakeFS to access cloud services (SDKs)
3 participants