Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade badger version from v3 to v4 #6780

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Upgrade badger version from v3 to v4 #6780

merged 1 commit into from
Oct 13, 2023

Conversation

nopcoder
Copy link
Contributor

@nopcoder nopcoder commented Oct 13, 2023 •
edited
Loading

Using a version from 2021, upgrade to latest.

"This is a major release because we are making a switch to SemVer in order to make it easier for the community to understand when breaking API and data format changes are made."

Close #6781

@nopcoder nopcoder added the include-changelog PR description should be included in next release changelog label Oct 13, 2023
@nopcoder nopcoder requested a review from a team October 13, 2023 07:10
@nopcoder nopcoder self-assigned this Oct 13, 2023
N-o-Z
N-o-Z requested changes Oct 13, 2023
View reviewed changes
Copy link
Member

@N-o-Z N-o-Z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, could this possibly also solve the arm64 issue that has been sighted? If so can we open and link an issue to this PR?

@nopcoder
Copy link
Contributor Author

Thanks, could this possibly also solve the arm64 issue that has been sighted? If so can we open and link an issue to this PR?

The arm64 issue looks like db was not closed properly by previous run. I'll have to try and reproduce it first.

N-o-Z
N-o-Z approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@N-o-Z N-o-Z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving change - regardless of the issue.
We should handle it though in a different context

@nopcoder nopcoder enabled auto-merge (squash) October 13, 2023 15:47
@nopcoder nopcoder merged commit 9154460 into master Oct 13, 2023
@nopcoder nopcoder deleted the chore/update-badger branch October 13, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@N-o-Z N-o-Z N-o-Z approved these changes

Assignees

@nopcoder nopcoder

Labels
include-changelog PR description should be included in next release changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KV badger package upgrade to v4
2 participants
@nopcoder @N-o-Z