Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "revert kv dynamodb client to use sdk v1 (#6706)" #6714

Merged
merged 1 commit into from
Oct 8, 2023
Merged

Revert "revert kv dynamodb client to use sdk v1 (#6706)" #6714

merged 1 commit into from
Oct 8, 2023

Conversation

nopcoder
Copy link
Contributor

@nopcoder nopcoder commented Oct 5, 2023

Open #6709

@nopcoder nopcoder added include-changelog PR description should be included in next release changelog minor-change Used for PRs that don't require issue attached labels Oct 5, 2023
@nopcoder nopcoder requested a review from N-o-Z October 5, 2023 16:01
@nopcoder nopcoder self-assigned this Oct 5, 2023
@nopcoder nopcoder enabled auto-merge (squash) October 5, 2023 16:08
itaiad200
itaiad200 previously requested changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@itaiad200 itaiad200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for now

@nopcoder nopcoder dismissed itaiad200’s stale review October 8, 2023 08:03

In case our route to fix the latest work with the new SDK we will revert again

@nopcoder nopcoder merged commit 822eb6d into master Oct 8, 2023
@nopcoder nopcoder deleted the revert/dynamo-sdk-v1 branch October 8, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@N-o-Z N-o-Z N-o-Z approved these changes

@itaiad200 itaiad200 itaiad200 left review comments

Assignees

@nopcoder nopcoder

Labels
include-changelog PR description should be included in next release changelog minor-change Used for PRs that don't require issue attached
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nopcoder @N-o-Z @itaiad200