Present technical conclusions from failed OC project #4815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arielshaqed
added
docs
talSofer
reviewed
Dec 18, 2022
| We assumed multiple non-functional and one functional requirements that did | ||
| not actually exist. We should have specified these requirements as part of | ||
| the design and communicated them with VE team. | ||
|
|
There was a problem hiding this comment.
I would add here -
The execution plan didn't precede experiments that could have helped us test our main premise quickly. If the main premise is - lakeFS OC is improving Spark write performance to lakeFS, we should start with experiments to test the assumption that we can achieve this main goal. Also, the goals should include concrete performance targets at the first place.
There was a problem hiding this comment.
Thanks! Added...
|
Pulling by force: this is a docs PR and functional tests are not blockers to pulling it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please add more in review!
Closes #4810.