Skip to content

Conversation

@efiop
Copy link
Contributor

@efiop efiop commented Dec 21, 2023

This is mainly needed for cloud versioning, to ensure that version_id is present for files inside a directory.

@codecov
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (499c2dd) 90.59% compared to head (be19061) 90.31%.
Report is 2 commits behind head on main.

Files Patch % Lines
dvc/testing/remote_tests.py 5.00% 19 Missing ⚠️
dvc/repo/index.py 12.50% 6 Missing and 1 partial ⚠️
dvc/testing/cloud.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10188      +/-   ##
==========================================
- Coverage   90.59%   90.31%   -0.28%     
==========================================
  Files         499      499              
  Lines       37912    37937      +25     
  Branches     5508     5513       +5     
==========================================
- Hits        34346    34264      -82     
- Misses       2924     3009      +85     
- Partials      642      664      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@efiop efiop changed the title [WIP] index: load meta from outs.files index: load meta from outs.files Dec 22, 2023
@efiop efiop marked this pull request as ready for review December 22, 2023 03:14
@efiop efiop merged commit 6a44783 into treeverse:main Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix fixes bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant