Skip to content

Conversation

@efiop
Copy link
Contributor

@efiop efiop commented Dec 14, 2023

We didn't care about this much because of our wrapper that makes all filesystems lazy no matter what, but having the base fs lazy is also useful and will be needed eventually.

@codecov
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (f3fa674) 90.62% compared to head (0751dac) 90.39%.

Files Patch % Lines
dvc/fs/dvc.py 92.68% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10166      +/-   ##
==========================================
- Coverage   90.62%   90.39%   -0.24%     
==========================================
  Files         500      500              
  Lines       37852    37871      +19     
  Branches     5503     5508       +5     
==========================================
- Hits        34305    34234      -71     
- Misses       2908     2976      +68     
- Partials      639      661      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@efiop efiop merged commit b121136 into treeverse:main Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant