Skip to content

Conversation

@daavoo
Copy link
Contributor

@daavoo daavoo commented Jul 26, 2022

DVC passes some values as rich.Text instead of string.
As an oversight in #69 , the refactor to use list_dict_to_dict_list removed this string casting, breaking dvc exp show --pcp

@daavoo daavoo self-assigned this Jul 26, 2022
@daavoo daavoo requested a review from pared July 26, 2022 07:53
@daavoo daavoo enabled auto-merge (rebase) July 26, 2022 07:53
@daavoo daavoo force-pushed the plotly-str-cast branch from e52609f to d8e7633 Compare July 26, 2022 08:14
DVC passes some values as `rich.Text` instead of string.
As an oversight in #69 , the refactor to use `list_dict_to_dict_list` removed this string casting, breaking `dvc exp show --pcp`
@daavoo daavoo force-pushed the plotly-str-cast branch from d8e7633 to 557b811 Compare July 26, 2022 08:18
@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2022

Codecov Report

Merging #73 (557b811) into main (4fe35d8) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
+ Coverage   95.73%   95.79%   +0.05%     
==========================================
  Files          19       19              
  Lines         633      642       +9     
  Branches       92       93       +1     
==========================================
+ Hits          606      615       +9     
  Misses         22       22              
  Partials        5        5              
Impacted Files Coverage Δ
src/dvc_render/plotly.py 100.00% <100.00%> (ø)
tests/test_parallel_coordinates.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fe35d8...557b811. Read the comment docs.

@daavoo daavoo merged commit f2a497a into main Jul 26, 2022
@daavoo daavoo deleted the plotly-str-cast branch July 26, 2022 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants