renderers: account for space in plots name #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Codecov Report
@@ Coverage Diff @@
## main #63 +/- ##
=======================================
Coverage 97.16% 97.16%
=======================================
Files 16 16
Lines 493 493
Branches 78 78
=======================================
Hits 479 479
Misses 8 8
Partials 6 6
Continue to review full report at Codecov.
|
daavoo
suggested changes
Jun 20, 2022
Contributor
daavoo
left a comment
daavoo
left a comment
There was a problem hiding this comment.
Would be nice to update test https://github.com/iterative/dvc-render/blob/ce75208b5558c6c5898265759b423a2a70486444/tests/test_renderer.py#L6
pared
force-pushed
the
allow_spaces_in_plots_names
branch
from
2f50c94 to
fb2a64f
Compare
Contributor
Author
|
@daavoo sorry, my bad, should be fixed |
daavoo
approved these changes
Jun 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
treeverse/dvc#7477 (comment)
cc @dberenbaum