toggle confusion matrix text #146
Conversation
dberenbaum
force-pushed
the
confusion-text
branch
from
fc0ee0a to
9836502
Compare
dberenbaum
force-pushed
the
confusion-text
branch
from
9836502 to
fdaab74
Compare
src/dvc_render/vega_templates.py
Outdated
| "facet": {"field": "rev", "type": "nominal"}, | ||
| "params": [ | ||
| { | ||
| "name": "toggleText", |
There was a problem hiding this comment.
[Q] Could we change this to be a single word like "values" to match "smooth" from the smooth/linear template?
There was a problem hiding this comment.
or showValues... unsure, just suggestions
There was a problem hiding this comment.
Yeah, I'll go with showValues. I don't like it either but couldn't find a way to have a nicely formatted name here.
Codecov ReportAll modified lines are covered by tests ✅
📢 Thoughts on this report? Let us know!. |
|
@dberenbaum should we release this now? |
|
Thanks @mattseddon. Forgot about this one. Merging now. |
|
Quick question, any reason this wasn't applied to the |
|
I can't remember off the top of my head. I would check if the floats for the normalized template look okay, but otherwise I don't see a reason not to add it there. |
3 participants
Closes:
After looking into this briefly, it was less work and more useful to add a toggle to turn text on or off.
Demo:
Screen.Recording.2023-10-16.at.4.05.57.PM.mov