Skip to content

Conversation

JLKwong
Copy link
Member

@JLKwong JLKwong commented Apr 15, 2021

No description provided.

@JLKwong JLKwong marked this pull request as ready for review April 21, 2021 21:38
@JLKwong JLKwong requested a review from rjpadilla April 21, 2021 21:38
@JLKwong JLKwong changed the title draft (fixes #2195) upgrade tests/test.sh with nonrpi command (fixes #2195) Apr 21, 2021
rjpadilla
rjpadilla previously approved these changes Apr 21, 2021
Copy link
Member

@rjpadilla rjpadilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised this worked. Good job 👍

./reb* ./ren* ./timezone* ./usb.bats ./verbose* ./version*
;;
*)
echo "Only 'all', 'services', 'led', 'magazine', 'wifi', 'ap', 'nonet', 'nonetblue' options are supported"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're adding nonrpi, shouldn't this be changed?

@rjpadilla rjpadilla dismissed their stale review April 21, 2021 22:49

Sorry Jaime tested on rpi, not on nonrpi :')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants