Skip to content

ui: added some placeholder handling and changed search node ui #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 23, 2023

Conversation

ArcaTech
Copy link
Contributor

Closes #134

This makes the changes suggested in the issue. I added a handlePlaceholder method to SearchNode, leaving the possibility for any Node type to do something with its placeholder text. The way I'm calling it in lib/ui/outline.tsx isn't consistent with the way it's called in the rest of the component, but I wasn't sure of the best way to have placeholder be available for the check on L160. That check (to decide whether to show the handle or not) was added because it looked weird when the placeholder was showing, but the handle wasn't.

I feel like there might be a better way of doing this so let me know what you think.

@progrium
Copy link
Contributor

Yea, maybe not ideal, but seems good enough. We can always change it later. Congrats on making your first hook in the system.

@progrium progrium merged commit a8a389c into treehousedev:main May 23, 2023
@ArcaTech ArcaTech deleted the ux-improvements-for-search-nodes branch May 30, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UX improvements for search nodes
2 participants