ui: added some placeholder handling and changed search node ui #166
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #134
This makes the changes suggested in the issue. I added a
handlePlaceholder
method toSearchNode
, leaving the possibility for any Node type to do something with its placeholder text. The way I'm calling it in lib/ui/outline.tsx isn't consistent with the way it's called in the rest of the component, but I wasn't sure of the best way to haveplaceholder
be available for the check on L160. That check (to decide whether to show the handle or not) was added because it looked weird when the placeholder was showing, but the handle wasn't.I feel like there might be a better way of doing this so let me know what you think.